Wr/coft NUTs #783
Closed
Wr/coft NUTs #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shetzel
reviewed
Oct 30, 2023
|
|
||
| execCmd(`project retrieve start -d ${objectTranslationPath} --json`, { | ||
| ensureExitCode: 0, | ||
| }); |
There was a problem hiding this comment.
This is retrieving a COT by filename, not directory. Also, I think we can't rely on just the exit code 0 as a success. I think we need to ensure the retrieve was written to the correct place and not the default location.
| 'customObject__c-es.objectTranslation-meta.xml' | ||
| ) | ||
| ) | ||
| ).to.be.true; |
There was a problem hiding this comment.
This isn't really retrieving across package dirs. It's retrieving a COT to the default location. I think we need a test that has COT and COFT and ensure it can be retrieved to the default package and to a specific non-default package. E.g., having a COT in my-app, deploying a COFT for that COT from outside of the project, then retrieving it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds MPD NUTs to COT/CFT flows
What issues does this PR fix or reference?
@W-13193003@
covers forcedotcom/cli#2124
will require: forcedotcom/source-deploy-retrieve#1146